[ENG-8927] Add dev mode for forcing errors/exceptions #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow force-triggering selected http errors in dev mode
* Allow force-throwing authentication exceptions only in dev mode
cslzchen
commented
Sep 14, 2025
Contributor
Author
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
For CR: as mentioned in other PRs, for overlayed and customized classes (CasServerProperties.java in this PR's case), only need to check the commented part for our customizations.
Comment on lines
+21
to
+23
| * <p>OSF CAS Customization: add {@link DevModeProperties devMode} to {@link CasServerProperties}; this allows | ||
| * dev mode options to be easily accessed from {@link org.apereo.cas.configuration.CasConfigurationProperties} | ||
| * by calling {@code casProperties.getServer().getDevMode()}.</p> |
Contributor
Author
There was a problem hiding this comment.
For CR: needs to overlay class CasServerProperties (cas.server in settings) to add our DevModeProperties (.dev-mode.* in settings), e.g.:
cas.server.dev-mode.allow-force-authn-exception=${ALLOW_FORCE_AUTHN_EXCEPTION:false}
cas.server.dev-mode.allow-force-http-error=${ALLOW_FORCE_HTTP_ERROR:false}
Comment on lines
+66
to
+68
| // OSF CAS Customization: a new private field devMode that stores osf-cas customized dev mode options | ||
| @NestedConfigurationProperty | ||
| private DevModeProperties devMode = new DevModeProperties(); |
Contributor
Author
There was a problem hiding this comment.
For CR: the only customization in this class is to simply adding DevModeProperties as NestedConfigurationProperty.
futa-ikeda
approved these changes
Sep 15, 2025
cslzchen
changed the title
Contributor
Author
|
Correction: should be |
cslzchen
merged commit ea4fb51
into
CenterForOpenScience:feature/angular-like-pages
1 check passed
cslzchen
added a commit
that referenced
this pull request
Sep 30, 2025
* Overlay CasServerProperties as of apereo-cas 6.2.8 * Create a new DevModeProperties to set dev mode options and add it to CasServerProperties * Enable dev mode for SimpleUrlHandlerMapping and OsfPrincipalFromNonInteractiveCredentialsAction * Only force-triggering selected http errors and authentication exceptions in dev mode
cslzchen
added a commit
that referenced
this pull request
Sep 30, 2025
…-pages Update CAS FE to match angular OSF * [ENG-8793] [ENG-8785] [ENG-8793] Remove branded login + Update no service pages + Update OAuth workflow (#98) * [ENG-8788] [ENG-8786] Institutions page and TOS page redesign (#99) * [ENG-8789] [ENG-8790] [ENG-8791] Exception Page rework (#95) * [ENG-8787] Username/password and 2FA login page (#97) * [ENG-8791] Inserting CasProperties into Spring Dispatcher and Improve header and left pane UI/UX (#92) * [ENG-8927] Add dev mode for forcing errors/exceptions (#93) * [NOTICKET] Remove OSF Collections URL from cas.properties (#91) * [ENG-8556] Update CAS pages to match Angular update: header, footer and left pane (#88) * [ENG-8754] Force throw a few HTTP errors for testing purpose (#90) * [ENG-8792] Force CAS to throw exceptions and display error pages (#87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8927
Purpose
Changes
See Purpose
Dev Notes
N/A
QA Notes
N/A
Dev-Ops Notes
ALLOW_FORCE_AUTHN_EXCEPTIONandALLOW_FORCE_HTTP_ERRORto true for staging and test serversALLOW_FORCE_AUTHN_EXCEPTIONandALLOW_FORCE_HTTP_ERRORto false for the production server