store: last-known-good snapshot fallback (kills 'Awaiting samples' after first publish)#1188
Merged
Merged
Conversation
…t publish) publishSnapshot writes an lkg copy without TTL on every success; readMaterialized falls back to it when the pointer/blob pair misses (worker outage past blob TTL, DEL race, transient). dataAsOf keeps the freshness badge honest about age. LKG write is best-effort and never fails the publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishSnapshot writes a no-TTL lkg copy on every success; readMaterialized falls back to it when the fresh pointer/blob path misses (worker outage > blob TTL, DEL race, transient redis error). A bench that has published once never collapses to the awaiting placeholder again; LiveIndicator keys off lastRunAt so lkg-served pages show the honest Stale badge.
Independent review: SHIP. tsc clean, 95 tests pass. Notes: Redis footprint ~doubles (bounded, worker-only sig set); lkg keys orphan on spec deletion (same as pointer keys, cleanup script someday).