fix: float view switcher in card top-right corner - #122
Merged
Conversation
User feedback: the bottom footer row I added for the view switcher created a visible gap because the row reserved its own band and the single button sat alone at the right edge with the rest of the row empty. Switch to absolute positioning in the card's top-right corner: the button sits inside the existing card padding, the chart fills the card top-to-bottom, no extra row reserved, no white gap. z-10 so the popover stays above the chart geometry. Default downward popover direction is fine again (room below the corner).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User : le footer row sous le chart créait un creux visible (button seul à droite, le reste vide).
Fix : absolute positioning dans le corner top-right du card. Le bouton se cale dans le padding du card existant, le chart fill top-to-bottom, plus de row réservée, plus de gap.