tsp-weekend-drift: add sample_size query (fixes '0 samples' display)#1317
Merged
Conversation
Spec was missing the sample_size query so the ledger + share-card footer showed '0 SAMPLES' regardless of actual probe count.
Adds count_over_time(tsp_deviation_bps{asset=X, market_state='closed'}[7d]) per provider — counts the number of closed-market samples over the past 7 days that feed the p50/p90/p99 aggregation window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing sample_size query made the ledger + share-card footer show '0 SAMPLES' regardless of actual probe count. Added count_over_time over 7d of closed-market samples per provider.