share-card snapshot: fix title/subtitle overlap (satori flex quirk)#1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot template's title + subtitle divs used bare
display: flexwhich in satori keeps the outer box at one-line height even when the text visually wraps. Long titles likeBest DEX for a $BOT market order, live slippage rankedon /benchmarks/perp-execution-quality then had the subtitle stacked on top of the title's wrapped second line (see screenshot in report).Fix: add
flexDirection: column+ explicitmaxWidthon both text boxes so satori measures the wrapped content height correctly. No behavior change for short titles.