hotfix: token-trade-coverage back to draft (needs 24h data)#1333
Merged
Conversation
…a before /benchmarks/[slug] page can render aggregate — previous deploy 404'd and rolled back)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bench 090 was flipped live in #1332 but the /benchmarks/token-trade-coverage detail page returns 404 because loadBenchmark returns undefined for a live bench that has no 24h avg_over_time samples yet — the harness only started collecting ~30 min ago. Sitemap smoke caught the 404 and rolled back the whole deploy.
Revert to status:draft so the page is excluded from sitemap. Harness keeps running; flip back to live after ~24h of Prom data accumulates.