fix(ledger): only render #1 chips on the leaderboard row#192
Merged
Conversation
Reported visually: on wallet-labels-coverage (11 chain dimensions), every row was showing all 11 chain chips (Ethereum, Solana, BNB Chain, Base, Arbitrum, Polygon, Optimism, TON, Stellar, XRP, Bitcoin) — most rendered as neutral 'not leading on this chain' chips. Total noise: ~44 chips across 4 rows. Default ChainCoverageChip to leaders-only mode. Non-leader chips are hard-skipped. The bench page chain tabs already provide precise per-chain rankings; this chip is a quick scan aid for 'where does this provider currently top the field' — that signal disappears when buried under 9 neutral chips per row. leadersOnly=false escape hatch kept so /products/[slug] (or any future consumer) can opt back into the full coverage view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported visually on wallet-labels-coverage (11 chain dimensions): every row was rendering all 11 chips, most as neutral 'not leading' tags → ~44 chips across 4 rows, completely overwhelming.
Default ChainCoverageChip to leaders-only mode on the bench leaderboard. Non-leader chips hard-skipped. The chain tabs on the bench already provide precise per-chain rankings; this chip is a quick scan aid for 'where does this provider top the field today' — that signal vanishes when buried under 9 neutral chips per row.
leadersOnly=falseescape hatch kept so /products/[slug] or future consumers can opt back into the full coverage view.