distribution: redesign as percentile whisker with landmark axis#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full rewrite of the distribution chart to address the "I click and other things appear/disappear, I can't read this" feedback.
What changed
Whisker shape per row — one continuous shape replaces the old 3-marker + band + median-guide combo: connector → p50 dot → thick p50→p90 bar → thinner p90→p99 tail → p99 wall. Silhouette encodes the spread story in one eye-jump; tooltip combines all three numbers in a single Hint.
Landmark axis above the rows — X axis snaps to power-of-10 decades formatted via `fmtUnit` (e.g. `100ms · 1s · 10s · 1min · 10min · 1h`). Tick labels live in a header rail above the rows and faint gridlines repeat per row, so the reader can decode any whisker's position back to a real value without hovering.
No more "shifting world" on exclude — toggling a provider rarely changes the visible landmarks (the floor / ceiling only move when data crosses a decade boundary). When they do move, the transition runs through the shared `useAnimatedDomain` hook (450 ms ease-out, 20 % significance threshold — same easing as the time-series chart's Y-axis re-zoom).
Excluded rows dim in place — the row keeps its grid slot and its rank #N. No reflow, no rank renumbering. Click anywhere on the row to re-include. A "Reset · N excluded" button appears in the header when any provider is hidden.
Stable rank column — `drop journal framing #1..#N` on the left, derived from the unchanging sort order. Lets the reader anchor on a row even when the row is dimmed.
Refactor
Removed