feat(worker): materialize venue dimension variants (pm-data-freshness + pm-api-latency)#730
Merged
Merged
Conversation
variantCombos() walked chain × region × kind only. Specs declaring dimensions.venue (pm-data-freshness, pm-api-latency) saw their venue tabs render in the UI but every variant request fell back to the unfiltered aggregate because the worker never materialized per-venue snapshots. Add venue to the cartesian product and propagate it through variantPath(). After this lands and the worker redeploys, /api/bench/<slug>/variant?venue=X returns the per-venue snapshot, and the Venue toggle on the bench page actually filters.
Flotapponnier
added a commit
that referenced
this pull request
Jun 26, 2026
Dev was force-pushed after PR #730 and the venue support in BenchmarkFilters (materialize/filters.ts) was lost in the spec/snapshot refactor PR #739. The worker still references f.venue and dims.venue, so typecheck failed. Re-add venue across: - BenchmarkFilters union (load.ts) - parseFilterSig allowlist - Spec.dimensions schema (spec-schema.ts) so YAML venue dim parses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: variantCombos() walked chain × region × kind. Specs declaring dimensions.venue (pm-data-freshness, pm-api-latency) saw the Venue toggle render in the bench page UI, but every click fell back to the unfiltered aggregate because the worker never pre-materialized per-venue snapshots.
Fix: add venue to the cartesian product in variantCombos() and propagate it through variantPath(). Backend was already venue-aware (BenchmarkFilters.venue, parseFilterSig, activeFilterLabels, injectLabels) — only the variant enumerator was missing it.
After merge + worker redeploy: clicking the Venue tab on /benchmarks/pm-data-freshness or /benchmarks/pm-api-latency filters the leaderboard to that venue's per-provider scores instead of returning the all-venues aggregate.