fix(products): badge URLs use raw bench slug, not canonical product slug#760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Product pages generate broken badge URLs whenever the URL slug aliases a different bench-level provider slug:
Found in audit (Ahrefs Patches): 4 broken image URLs across publicnode, polygon, publicnode-feehistory product pages.
Root cause
`badgeCards.push(...)` used `p.slug` (canonical product slug from URL params) in the badge URL, but the `/api/badge/[bench]/[provider]` route is keyed by the bench's raw result slug. Aliases like `PRODUCT_ALIASES = { "publicnode-feehistory": "publicnode", "matic-usd": "polygon" }` collapse multiple bench providers under one canonical product, breaking the badge URL.
Fix
Capture `providerSlug = a.result.slug` (the raw bench-level slug, available in the loop) and use it in the badge URL instead of `p.slug`.