fix(hl-frontends): don't linkify raw hex builder slugs (404 fix)#771
Merged
Conversation
added 4 commits
June 28, 2026 12:27
The HL frontends bench leaderboard renders one row per builder. When a builder address isn't yet in /opt/hl-bench/builders.json, the row slug stays as a truncated 8-char hex prefix (e.g. 0x557edb25). The ledger-table component unconditionally wraps every row name in a <Link href='/products/<slug>'>, but /products/<hex> is blacklisted in providers.ts (HEX_ADDRESS_SLUG regex), so the link 404s. Now hex slugs render as plain text — same path as region slugs — until the builder gets identified and added to builders.json, at which point the slug becomes a real name and the link reappears.
providers.ts is server-only (unstable_cache + bench loaders); importing isHexAddressSlug from it into this 'use client' component breaks Turbopack build. Inline the regex check instead, same pattern as the existing isRegion/isAll inline checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On `/benchmarks/hyperliquid-frontends`, builder rows whose address isn't in `builders.json` show up with a truncated hex slug (e.g. `0x557e…3c81`). The ledger-table renderer unconditionally wrapped every name in a `<Link href=/products/>`, but `/products/` is blacklisted by PR #747's `HEX_ADDRESS_SLUG` regex → click = 404.
Reported by user: "les hyperliens sont cassés sur les adresses type 0x557e…3c81".
Fix
When a builder gets identified and added to `/opt/hl-bench/builders.json` (deep-research in progress), its slug becomes the kebab name → link reappears automatically.
Test plan after deploy