fix(bench): drop broken providers, fix validator p90/p99 aggregation#85
Merged
Conversation
- l1-finality: remove cardano (harness fetch broken, 49 errors, health=0) - solana-tx-landing-latency: remove 0slot (no probe data in prom) - validator-yield: replace quantile_over_time(per-validator series) with quantile(across validators) so p90/p99 aggregate properly instead of picking result[0] which often hit a 0% APY validator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardano(harness fetch broken, 49 errors, health=0). Page was showing<1sfinality which is wrong.0slot(no probe data in Prom). Page was showing 0ms / 0% in rank drop journal framing #1.solana&hyperliquidp90/p99 queries — replacequantile_over_time(0.X, per_validator[24h])withquantile(0.X, per_validator). Old query returned 200 series, code pickedresult[0]which was often a 0% APY validator.Test plan
bun run buildpasses