Fix CSRF middleware planned before introducing any cookie-based auth - #405
Merged
kilodesodiq-arch merged 1 commit intoJul 22, 2026
Merged
Conversation
…e flag - Implement CsrfMiddleware using the double-submit-cookie pattern - Guard behind CSRF_PROTECTION_ENABLED=true environment variable - Parse cookies from Cookie header (no cookie-parser dependency) - Constant-time token comparison to prevent timing attacks - Set SameSite=strict, secure in production, 1-hour expiry - Add comprehensive unit tests (13 tests covering all scenarios) - Add docs/security/csrf-posture.md with contract and client guide - Update security.module.ts posture comment to reference new middleware Closes ChainForgee#217
ifygreg01-best
pushed a commit
to ifygreg01-best/ChainForge
that referenced
this pull request
Jul 23, 2026
…e flag (ChainForgee#405) - Implement CsrfMiddleware using the double-submit-cookie pattern - Guard behind CSRF_PROTECTION_ENABLED=true environment variable - Parse cookies from Cookie header (no cookie-parser dependency) - Constant-time token comparison to prevent timing attacks - Set SameSite=strict, secure in production, 1-hour expiry - Add comprehensive unit tests (13 tests covering all scenarios) - Add docs/security/csrf-posture.md with contract and client guide - Update security.module.ts posture comment to reference new middleware Closes ChainForgee#217 Co-authored-by: ZionApprove <zionapprove@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a production-ready double-submit-cookie CSRF middleware guarded behind the
CSRF_PROTECTION_ENABLEDfeature flag, while maintaining the existing security posture where CSRF is mitigated by design (API-key header auth).Changes
src/common/security/csrf.middleware.ts— double-submit-cookie CSRF middleware with:Cookieheader (nocookie-parserdependency)crypto.randomBytescrypto.timingSafeEqualSameSite=strict, secure in production, 1-hour expiryCSRF_PROTECTION_ENABLED=truesrc/common/security/csrf.middleware.spec.ts— 13 unit tests covering:docs/security/csrf-posture.md— documentation covering:main.tsto conditionally register CSRF middlewaresecurity.module.tsposture comment to reference the new middlewareCloses #217