docs: reference #104 and #106 at the code that already fixes them - #181
Merged
DeFiVC merged 1 commit intoJul 28, 2026
Merged
Conversation
…the code that already fixes them Both issues are already resolved — commit 71a9b54 landed the isPending gate in reward.service.ts (ChainLearnOfficial#104: credits are no longer granted on an unconfirmed bad_seq outcome) and the unique-violation recovery in idempotency.ts (ChainLearnOfficial#106: the concurrent-insert race returns the cached response instead of a raw 500) the day before this branch's parent history. Verified both are present and unreverted in current main. Neither had a PR with a closing reference, so they were still showing as open despite the underlying bug being fixed. Adding a short comment at each fix site (no behavior change) so this PR has something concrete to point at while closing out the stale tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both #104 and #106 are already resolved in the code — neither had a PR with a closing reference, so they've stayed open on GitHub despite the underlying bugs being fixed.
71a9b54added theisPendinggate inreward.service.ts— credits are only granted once the transaction is confirmed, not on the uncertainpending_indexer_confirmationoutcome. Present in bothprocessRewardClaimandclaimReward.23505), and returns the cached response instead of letting the race surface as a raw 500. Present inidempotency.ts.Verified both fixes directly against
mainwhile working a previous PR from the same audit batch that covered two related issues in this repo — see that PR's description for the full diff comparison against71a9b54.Changes
No behavior change — added a short comment at each fix site referencing the issue number, so this PR has something concrete to close them against.
closes #104
closes #106
Test plan
npx vitest run tests/unit/— 93/99 passing, same 6 pre-existing failures asmain(tracing.test.ts,stellar/client.test.ts,middleware/error-handler.test.ts,stellar/transactions.test.ts) — nothing newnpx tsc --noEmit— cleannpx eslinton both files — 0 errors (1 pre-existing unrelated warning)