chore: add .dockerignore to reduce Docker build context - #201
Merged
DeFiVC merged 2 commits intoJul 29, 2026
Conversation
Node.js running as PID 1 does not forward OS signals (SIGTERM, SIGINT) to child processes and does not reap zombie processes. Without an init process, SIGTERM sent by Docker/Kubernetes during shutdown may not reach the app, causing it to be forcibly killed after the stop timeout. Fix: install tini via apk in the base stage and set it as ENTRYPOINT in the production stage. Tini runs as PID 1, correctly forwards signals to the Node.js process, and reaps any zombie child processes. Closes ChainLearnOfficial#166
Exclude node_modules, .git, tests, dist, and other dev-only files from the Docker build context to speed up builds and avoid leaking unnecessary files into the image layers. Closes ChainLearnOfficial#164
|
@Harkinkunmi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
.dockerignorefile to prevent unnecessary files from being sent to the Docker daemon during builds.Problem
Without
.dockerignore, the build context includes large/irrelevant directories likenode_modules,.git, andtests, making builds significantly slower.Changes
node_modules(reinstalled fresh vianpm ciin the build stage).gitand.githubtestsandsrc/testdist(rebuilt in Docker).envfiles, logs, dev config files, editor/OS artifactsCloses #164