ci: run lint and test jobs in parallel - #202
Merged
DeFiVC merged 3 commits intoJul 29, 2026
Merged
Conversation
Remove eeds: lint-and-typecheck from the test job so both jobs start simultaneously. Each job already does its own checkout and npm ci, so there is no shared state requiring serialization. Closes ChainLearnOfficial#169
|
@Harkinkunmi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…mer.ts The block comment before WARM_PAGE_LIMIT was missing its closing */, causing the constant and the entire warmCourseCache function body to be swallowed into the comment. ESLint then misread totalPages as never reassigned (prefer-const error) because it could not see the assignment inside the do-while loop. Also adds the missing cacheKey and cacheSet imports from ./index.js that were used but not imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
nnThetestjob hadneeds: lint-and-typecheck, forcing it to wait for lint/typecheck to finish before even starting Postgres and Redis. Since both jobs are fully independent (each does its own checkout andnpm ci), this serialisation was unnecessary.nn## ChangennRemoveneeds: lint-and-typecheckfrom thetestjob so the two jobs run concurrently.nn## Resultnn- Wall-clock CI time reduced by roughly the lint/typecheck job duration (~1-2 min).`n- No behavioural change: failures in either job still block the PR.