chore: downgrade dup msg log#6884
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplace a single Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/libp2p/service.rs`:
- Around line 446-447: The current publish error is always logged at debug
level; instead match the gossipsub::PublishError returned by
swarm.behaviour_mut().publish(...) and only treat PublishError::Duplicate as
debug, while logging all other variants (SigningError, MessageTooLarge,
TransformFailed, AllQueuesFull, etc.) at warn! (or higher). Update the code
around swarm.behaviour_mut().publish(topic, message) to pattern-match the Err(e)
into gossipsub::PublishError and call debug! for Duplicate but warn! for any
other variant so real networking/configuration issues remain visible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c161ae80-82e7-4b19-8c96-605f51dd4520
📒 Files selected for processing (1)
src/libp2p/service.rs
2cf4a77
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Duplicates are not really errors. We republish messages on new tipsets, but if they are already there it shouldn't trigger an error log.
See https://github.com/libp2p/go-libp2p-pubsub/blob/ed53c170f9a784c45f81d88dd6051218fbd5ece7/topic.go#L240-L242
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit