Skip to content

chore: downgrade dup msg log #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LesnyRumcajs merged 2 commits into from
Apr 9, 2026
Merged

chore: downgrade dup msg log #6884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd0d757
chore: downgrade dup msg log
LesnyRumcajs Apr 9, 2026
2cf4a77
only ignore duplicates
LesnyRumcajs Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/libp2p/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,16 @@ async fn handle_network_message(
) {
match message {
NetworkMessage::PubsubMessage { topic, message } => {
if let Err(e) = swarm.behaviour_mut().publish(topic, message) {
warn!("Failed to send gossipsub message: {:?}", e);
match swarm.behaviour_mut().publish(topic, message) {
Ok(_) => (),
Err(gossipsub::PublishError::Duplicate) => {
// Safe to ignore, the message has already been published and deduped by gossipsub, so no need to log this as a warning.
// This matches `go-libp2p-pubsub` behavior https://github.com/libp2p/go-libp2p-pubsub/blob/v0.15.0/topic.go#L240-L242
debug!("Failed to send gossipsub message: duplicate");
}
Err(e) => {
warn!("Failed to send gossipsub message: {e:#}");
}
}
}
NetworkMessage::HelloRequest {
Expand Down
Loading