Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds NV28/FireHorse support for devnet: new devnet actor manifest and bundle CID, actor-bundle registration, devnet height info updated to reference the bundle, state migration wired for FireHorse, and devnet container env/image/build updates. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
155a803 to
4f7bde5
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/devnet/.env (1)
25-26: Optional: reorder dotenv keys to silence linter warnings.
dotenv-linterreports unordered keys forFIREHORSE_HEIGHTandTARGET_HEIGHT. Not functionally blocking, but worth cleaning up to keep lint output quiet.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/devnet/.env` around lines 25 - 26, Reorder the two dotenv entries so keys are alphabetically ordered to satisfy dotenv-linter: swap the lines for FIREHORSE_HEIGHT and TARGET_HEIGHT so TARGET_HEIGHT appears before FIREHORSE_HEIGHT, keeping their values unchanged; this small reordering (affecting the keys TARGET_HEIGHT and FIREHORSE_HEIGHT) will silence the linter warning.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/devnet/.env`:
- Around line 25-26: Reorder the two dotenv entries so keys are alphabetically
ordered to satisfy dotenv-linter: swap the lines for FIREHORSE_HEIGHT and
TARGET_HEIGHT so TARGET_HEIGHT appears before FIREHORSE_HEIGHT, keeping their
values unchanged; this small reordering (affecting the keys TARGET_HEIGHT and
FIREHORSE_HEIGHT) will silence the linter warning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ca538500-c9b6-4dcb-a91e-572b3c435e2e
📒 Files selected for processing (7)
build/manifest.jsonscripts/devnet/.envscripts/devnet/docker-compose.ymlscripts/devnet/lotus.dockerfilesrc/networks/actors_bundle.rssrc/networks/devnet/mod.rssrc/state_migration/mod.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/devnet/check.sh`:
- Line 29: The inline comment documenting the timeout value is stale — update
the earlier comment that mentions 300s to reflect the new 360s value so it
matches the computed timeout variable (timeout=$((start_time + 360))) and avoids
CI confusion; search for the comment referencing "300s" or "5 minutes" in the
same script and change it to "360s" or "6 minutes" to match the timeout
computation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 96ff29ca-8ae1-4697-8b66-131bdd686272
📒 Files selected for processing (1)
scripts/devnet/check.sh
9678864 to
5061a23
Compare
- Pin lotus to d036ad9 and forest to nv28-2k-testing (post-NV28 binaries) - Rename XX_HEIGHT → FIREHORSE_HEIGHT across every profile (matches FOREST_FIREHORSE_HEIGHT / LOTUS_FIREHORSE_HEIGHT expected by the new binaries, per ChainSafe/forest#6943) - Lower GOLDENWEEK=20 / FIREHORSE=50 in all profiles so every run spends most of its time in post-NV28 state - Refactor upgrade_vectors.go to multi-boundary with per-assertion boundary labels; adds doChainProgressAcrossBoundary (Sometimes, stall detector) and doPostUpgradeNodeHealth (Sometimes, robust to Antithesis fault injection); null-tipset guard on upgrade activation - DoUpgradeSuite remains gated to env.fip only (weight 0 elsewhere) so the other profiles' reports stay focused on their own scope Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #6913
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Chores
Documentation