Skip to content

fix: simplify docker-compose.yml for api compare tests - #7437

Merged
hanabi1224 merged 1 commit into
mainfrom
hm/simplify-api-compare-docker-compose
Aug 4, 2026
Merged

fix: simplify docker-compose.yml for api compare tests#7437
hanabi1224 merged 1 commit into
mainfrom
hm/simplify-api-compare-docker-compose

Conversation

@hanabi1224

@hanabi1224 hanabi1224 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

  • merge forest-index-backfill into forest-rpc-ready

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Refactor
    • Integrated index backfill into the RPC readiness process.
    • Simplified service startup by removing the standalone index backfill service and redundant dependencies.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Changes

API comparison readiness

Layer / File(s) Summary
Run index backfill during RPC readiness
scripts/tests/api_compare/docker-compose.yml
forest-rpc-ready extracts the snapshot epoch and runs forest-cli index backfill. The standalone forest-index-backfill service is removed.
Align API comparison dependencies
scripts/tests/api_compare/docker-compose.yml
api-compare and api-compare-gateway no longer depend directly on forest-index-backfill.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: lesnyrumcajs, sudo-shashank

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: simplifying the Docker Compose configuration for API comparison tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/simplify-api-compare-docker-compose
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/simplify-api-compare-docker-compose

Comment @coderabbitai help to get the list of available commands.

@hanabi1224
hanabi1224 marked this pull request as ready for review August 4, 2026 08:59
@hanabi1224
hanabi1224 requested a review from a team as a code owner August 4, 2026 08:59
@hanabi1224
hanabi1224 requested review from EclesioMeloJunior and LesnyRumcajs and removed request for a team August 4, 2026 08:59
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (81f6cba) to head (dabf33f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f6cba...dabf33f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanabi1224
hanabi1224 added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit 43dd059 Aug 4, 2026
89 of 114 checks passed
@hanabi1224
hanabi1224 deleted the hm/simplify-api-compare-docker-compose branch August 4, 2026 09:53
@coderabbitai coderabbitai Bot mentioned this pull request Aug 4, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants