Skip to content

chore: apply clippy inlined-format-args - #7561

Merged
LesnyRumcajs merged 1 commit into
mainfrom
inlined-format-args
Aug 27, 2026
Merged

chore: apply clippy inlined-format-args#7561
LesnyRumcajs merged 1 commit into
mainfrom
inlined-format-args

Conversation

@LesnyRumcajs

@LesnyRumcajs LesnyRumcajs commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • one less thing to pester about in PRs

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Enabled a workspace lint to encourage modern Rust format-string syntax.
    • Updated diagnostic messages, logs, assertions, and displayed values to use inline formatting.
    • Preserved existing error messages, validation behavior, runtime behavior, and public APIs.

@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code owner August 27, 2026 13:56
@LesnyRumcajs
LesnyRumcajs requested review from EclesioMeloJunior and akaladarshi and removed request for a team August 27, 2026 13:56
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5ad737f8-bcfc-4f66-9587-d56c108b0bc8

📥 Commits

Reviewing files that changed from the base of the PR and between 5976f3d and a7f49f4.

📒 Files selected for processing (34)
  • Cargo.toml
  • src/chain_sync/sync_status.rs
  • src/chain_sync/tipset_syncer.rs
  • src/daemon/db_util.rs
  • src/db/migration/migration_map.rs
  • src/dev/subcommands/update_checkpoints_cmd.rs
  • src/eth/eip_155_transaction.rs
  • src/eth/homestead_transaction.rs
  • src/eth/transaction.rs
  • src/fil_cns/validation.rs
  • src/interpreter/externs.rs
  • src/interpreter/vm.rs
  • src/message/mod.rs
  • src/rpc/methods/eth/filter/mod.rs
  • src/rpc/methods/eth/trace/parity.rs
  • src/rpc/methods/eth/utils.rs
  • src/rpc/methods/state.rs
  • src/rpc/mod.rs
  • src/rpc/registry/actors_reg.rs
  • src/shim/actors/builtin/power/mod.rs
  • src/shim/crypto.rs
  • src/shim/machine/manifest.rs
  • src/shim/sector.rs
  • src/shim/state_tree_v0.rs
  • src/state_manager/chain_rand.rs
  • src/state_manager/utils.rs
  • src/state_migration/nv17/migration.rs
  • src/state_migration/nv18/migration.rs
  • src/state_migration/nv19/migration.rs
  • src/tool/subcommands/api_cmd/stateful_tests.rs
  • src/tool/subcommands/archive_cmd.rs
  • src/tool/subcommands/snapshot_cmd.rs
  • src/utils/net/download_file.rs
  • src/utils/proofs_api/paramfetch.rs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • filecoin-project/lotus (manual)

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The workspace enables the uninlined_format_args Clippy warning. Rust logs, errors, display implementations, and test diagnostics now use captured format arguments. Runtime behavior and public interfaces remain unchanged.

Changes

Captured format argument migration

Layer / File(s) Summary
Lint enforcement and core formatting
Cargo.toml, src/chain_sync/*, src/daemon/db_util.rs, src/db/migration/migration_map.rs, src/dev/subcommands/update_checkpoints_cmd.rs
The workspace enables the lint. Core logs, display implementations, and migration messages capture local values directly.
Transaction and runtime diagnostics
src/eth/*, src/fil_cns/validation.rs, src/interpreter/*, src/message/mod.rs
Transaction validation, runtime errors, and test diagnostics use captured formatting without changing control flow.
RPC error and display formatting
src/rpc/methods/eth/*, src/rpc/methods/state.rs, src/rpc/mod.rs, src/rpc/registry/actors_reg.rs
RPC errors and display output use captured format arguments with equivalent messages.
Shim, migration, and tooling formatting
src/shim/*, src/state_manager/*, src/state_migration/*, src/tool/*, src/utils/*
Shim, migration, command, download, upload, and API diagnostics use captured formatting. Related test assertions are updated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a7f49

This PR applies a mechanical Rust formatting lint cleanup without a documented behavior change or concrete production risk; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: akaladarshi, eclesiomelojunior, hanabi1224

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 54.35% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 33 files. (1 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly describes the main change: applying the Clippy format-argument lint across the codebase.
Full details: Docstring Coverage

Explanation

Docstring coverage is 54.35% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 33 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch inlined-format-args
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch inlined-format-args

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.11111% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.73%. Comparing base (0ee9e00) to head (934ad8d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/shim/actors/builtin/power/mod.rs 0.00% 7 Missing and 2 partials ⚠️
src/tool/subcommands/archive_cmd.rs 0.00% 6 Missing ⚠️
src/utils/net/download_file.rs 42.85% 2 Missing and 2 partials ⚠️
src/rpc/methods/eth/filter/mod.rs 0.00% 2 Missing and 1 partial ⚠️
src/daemon/db_util.rs 0.00% 2 Missing ⚠️
src/dev/subcommands/update_checkpoints_cmd.rs 0.00% 2 Missing ⚠️
src/rpc/methods/eth/utils.rs 0.00% 1 Missing and 1 partial ⚠️
src/rpc/methods/state.rs 0.00% 1 Missing and 1 partial ⚠️
src/chain_sync/tipset_syncer.rs 0.00% 0 Missing and 1 partial ⚠️
src/db/migration/migration_map.rs 0.00% 1 Missing ⚠️
... and 16 more
Additional details and impacted files
Files with missing lines Coverage Δ
src/chain_sync/sync_status.rs 24.13% <ø> (ø)
src/eth/transaction.rs 87.50% <100.00%> (-0.30%) ⬇️
src/message/mod.rs 92.24% <ø> (ø)
src/rpc/registry/actors_reg.rs 96.03% <100.00%> (ø)
src/shim/crypto.rs 90.53% <100.00%> (ø)
src/shim/machine/manifest.rs 80.64% <ø> (ø)
src/chain_sync/tipset_syncer.rs 65.20% <0.00%> (ø)
src/db/migration/migration_map.rs 89.74% <0.00%> (ø)
src/eth/eip_155_transaction.rs 85.16% <0.00%> (ø)
src/eth/homestead_transaction.rs 77.04% <0.00%> (ø)
... and 22 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee9e00...934ad8d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit b68a929 Aug 27, 2026
35 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the inlined-format-args branch August 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants