Skip to content

chore: enable more perf lints - #7562

Merged
LesnyRumcajs merged 1 commit into
inlined-format-argsfrom
enable-more-perf-lints
Aug 27, 2026
Merged

chore: enable more perf lints#7562
LesnyRumcajs merged 1 commit into
inlined-format-argsfrom
enable-more-perf-lints

Conversation

@LesnyRumcajs

@LesnyRumcajs LesnyRumcajs commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • enabled more perf lints and fixed offenses
  • the interop clippy checks were never exercised due to lack of --workspace.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code owner August 27, 2026 14:59
@LesnyRumcajs
LesnyRumcajs requested review from EclesioMeloJunior and sudo-shashank and removed request for a team August 27, 2026 14:59
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 50c63c02-7b8e-45d6-aaca-0ab759a16953

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@LesnyRumcajs
LesnyRumcajs force-pushed the enable-more-perf-lints branch from 78c81af to a27494a Compare August 27, 2026 15:00
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.73%. Comparing base (934ad8d) to head (a27494a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/rpc/methods/eth.rs 0.00% 4 Missing and 1 partial ⚠️
src/chain_sync/network_context.rs 0.00% 1 Missing ⚠️
src/state_manager/mod.rs 0.00% 0 Missing and 1 partial ⚠️
src/state_manager/utils.rs 0.00% 0 Missing and 1 partial ⚠️
src/tool/subcommands/api_cmd/test_snapshot.rs 0.00% 1 Missing ⚠️
src/tool/subcommands/benchmark_cmd.rs 0.00% 1 Missing ⚠️
src/utils/net/download_file.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/cli/subcommands/info_cmd.rs 84.53% <100.00%> (ø)
src/cli/subcommands/mpool_cmd.rs 67.41% <100.00%> (ø)
src/cli_shared/cli/mod.rs 77.52% <100.00%> (ø)
src/daemon/mod.rs 24.68% <100.00%> (+0.32%) ⬆️
src/db/memory.rs 93.70% <100.00%> (+0.02%) ⬆️
src/libp2p_bitswap/bitswap_pb.rs 53.14% <ø> (+0.69%) ⬆️
src/message_pool/msgpool/test_provider.rs 99.01% <100.00%> (-0.01%) ⬇️
src/message_pool/nonce_tracker.rs 96.77% <100.00%> (ø)
src/networks/mod.rs 90.34% <100.00%> (ø)
src/shim/actors/convert.rs 100.00% <100.00%> (ø)
... and 8 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934ad8d...a27494a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit ab77e08 Aug 27, 2026
39 of 71 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the enable-more-perf-lints branch August 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants