Skip to content

chore: bump toolchain to rust-1.98.0 - #7568

Merged
LesnyRumcajs merged 1 commit into
mainfrom
bump-rust-1.98
Aug 31, 2026
Merged

chore: bump toolchain to rust-1.98.0#7568
LesnyRumcajs merged 1 commit into
mainfrom
bump-rust-1.98

Conversation

@LesnyRumcajs

@LesnyRumcajs LesnyRumcajs commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • bumps toolchain to Rust 1.98.0 and fixes new clippy lints, result_large_err, chunks_exact_to_as_chunks, unused_imports (not sure why it wasn't caught earlier), useless_format.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Maintenance

    • Updated the project’s Rust toolchain to version 1.98.0.
    • Improved internal block-validation error handling during chain synchronization.
    • Streamlined hash processing for more efficient indexing operations.
  • Tests

    • Simplified assertions in RPC and checksum tests without changing runtime behavior.
    • Removed an unused test-only import.

@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code owner August 31, 2026 16:37
@LesnyRumcajs
LesnyRumcajs requested review from EclesioMeloJunior and akaladarshi and removed request for a team August 31, 2026 16:37
@LesnyRumcajs
LesnyRumcajs enabled auto-merge August 31, 2026 16:37
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 00df0500-b4f0-492f-9a2f-e7bcc4aecd2d

📥 Commits

Reviewing files that changed from the base of the PR and between 1d06155 and 6960197.

📒 Files selected for processing (6)
  • rust-toolchain.toml
  • src/chain_sync/tipset_syncer.rs
  • src/cli/humantoken.rs
  • src/db/car/forest/index/hash.rs
  • src/rpc/methods/eth/utils.rs
  • src/utils/io/writer_checksum.rs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • filecoin-project/lotus (manual)
💤 Files with no reviewable changes (1)
  • src/cli/humantoken.rs

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The pull request updates Rust from 1.97.0 to 1.98.0, boxes tipset validation errors, simplifies hash chunk processing, and removes redundant test code.

Changes

Rust compatibility updates

Layer / File(s) Summary
Boxed tipset validation errors
src/chain_sync/tipset_syncer.rs
validate_block returns boxed CID and sync-error tuples. validate_tipset destructures these errors before handling and propagating them.
Hash chunk processing
src/db/car/forest/index/hash.rs
summary uses complete eight-byte chunks from as_chunks::<8>() while preserving the existing hash folding behavior.
Toolchain and test updates
rust-toolchain.toml, src/cli/humantoken.rs, src/rpc/methods/eth/utils.rs, src/utils/io/writer_checksum.rs
The Rust toolchain advances to 1.98.0. Tests remove an unused import and redundant string formatting.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 69601

This PR updates the Rust toolchain and applies localized lint fixes without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested reviewers: akaladarshi, eclesiomelojunior, hanabi1224

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 4 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: updating the Rust toolchain to version 1.98.0. It is concise and specific. The Clippy fixes are secondary changes and do not require inclusion in the t…
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 4 files. (1 skipped: 1 unsupported.)

Full details: Title check

Explanation

The title clearly identifies the primary change: updating the Rust toolchain to version 1.98.0. It is concise and specific. The Clippy fixes are secondary changes and do not require inclusion in the title.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-rust-1.98
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch bump-rust-1.98

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.85%. Comparing base (e3d4268) to head (6960197).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/chain_sync/tipset_syncer.rs 11.11% 3 Missing and 5 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/cli/humantoken.rs 99.35% <ø> (ø)
src/db/car/forest/index/hash.rs 100.00% <100.00%> (ø)
src/rpc/methods/eth/utils.rs 89.64% <100.00%> (ø)
src/utils/io/writer_checksum.rs 82.40% <100.00%> (ø)
src/chain_sync/tipset_syncer.rs 65.00% <11.11%> (-0.21%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d06155...6960197. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Aug 31, 2026
Merged via the queue into main with commit 71b6d4b Aug 31, 2026
35 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the bump-rust-1.98 branch August 31, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants