Skip to content

fix(ci): set the forest entrypoint in the external RPC checks - #7570

Merged
LesnyRumcajs merged 1 commit into
mainfrom
fix/rpc-checks-forest-entrypoint
Sep 1, 2026
Merged

fix(ci): set the forest entrypoint in the external RPC checks#7570
LesnyRumcajs merged 1 commit into
mainfrom
fix/rpc-checks-forest-entrypoint

Conversation

@EclesioMeloJunior

@EclesioMeloJunior EclesioMeloJunior commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • Sets entrypoint: ["forest"] explicitly on the forest service in scripts/tests/external-rpc-checks/docker-compose.yaml.
  • When building a proper image from a ref we use scripts/devnet/forest_ci.dockerfile that does not expose any entrypoint, causing exec: "--chain=calibnet": executable file not found in $PATH

Reference issue to close (if applicable)

unblocks #7569

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Improved container startup reliability by explicitly setting the service entrypoint.

@EclesioMeloJunior
EclesioMeloJunior requested a review from a team as a code owner August 31, 2026 23:08
@EclesioMeloJunior
EclesioMeloJunior requested review from LesnyRumcajs and sudo-shashank and removed request for a team August 31, 2026 23:08
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Essentials

Run ID: 3e79364a-0e54-4bba-889c-57036872a6f8

📥 Commits

Reviewing files that changed from the base of the PR and between 0ef95f2 and 1c78733.

📒 Files selected for processing (1)
  • scripts/tests/external-rpc-checks/docker-compose.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • filecoin-project/lotus (manual)

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The external RPC check configuration now sets forest as the explicit entrypoint for the forest service.

Changes

External RPC checks

Layer / File(s) Summary
Forest service entrypoint
scripts/tests/external-rpc-checks/docker-compose.yaml
The forest service now defines forest as its container entrypoint.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1c787

This explicitly restores the Forest entrypoint for the external RPC checks, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: lesnyrumcajs, sudo-shashank, akaladarshi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: setting the forest entrypoint for external RPC checks.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rpc-checks-forest-entrypoint
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/rpc-checks-forest-entrypoint

Comment @coderabbitai help to get the list of available commands.

@EclesioMeloJunior EclesioMeloJunior changed the title fix(ci): set the forest entrypoint in the external RPC checks compose fix(ci): set the forest entrypoint in the external RPC checks Aug 31, 2026
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.83%. Comparing base (0ef95f2) to head (1c78733).
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef95f2...1c78733. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 54da45b Sep 1, 2026
39 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the fix/rpc-checks-forest-entrypoint branch September 1, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants