Merged
Conversation
ansermino
force-pushed
the
david/p2p-tests
branch
from
e808a3e to
40b8647
Compare
noot
approved these changes
May 27, 2019
dutterbutter
approved these changes
May 27, 2019
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Force CI run * Re-enabled tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After extensive testing I have concluded that the ping/send tests that are failing are very difficult to reproduce. They are failing (at times) both locally and on CI. I am proposing we re-enable the tests and start trying to collect bug reports to help diagnose the issue.
NOTE ~ Something very helpful I learned:
Changes
Tests:
Fixes: Closes #92