fix!: require writable external buffer storage - #58
Merged
Conversation
GrapeBaBa
marked this pull request as ready for review
July 21, 2026 07:22
nazarhussain
requested changes
Jul 23, 2026
GrapeBaBa
changed the title
nazarhussain
approved these changes
Jul 27, 2026
nazarhussain
pushed a commit
that referenced
this pull request
Aug 18, 2026
🤖 I have created a release *beep* *boop* --- ## [4.0.0](zapi-v3.1.0...zapi-v4.0.0) (2026-08-18) ### ⚠ BREAKING CHANGES * isolate DSL class tags across addons ([#67](#67)) * manage external buffer lifetime ([#66](#66)) * require writable external buffer storage ([#58](#58)) ### Features * add owned typed arrays ([#68](#68)) ([b92c2de](b92c2de)) * **js:** add exact u32 conversion ([#71](#71)) ([d6b21e1](d6b21e1)) * **js:** add typed array toArray ([#70](#70)) ([ab42ab0](ab42ab0)) * **js:** export module/namespace consts and enums ([#73](#73)) ([76dc0db](76dc0db)) ### Bug Fixes * **dsl:** support class pointer arguments ([#50](#50)) ([9dd2111](9dd2111)) * harden N-API boundary against JS-triggerable memory bugs ([#60](#60)) ([fff76f3](fff76f3)) * isolate DSL class tags across addons ([#67](#67)) ([3ab8c11](3ab8c11)) * manage external buffer lifetime ([#66](#66)) ([d134a6a](d134a6a)) * **napi:** receive raw pointer out parameters ([#57](#57)) ([fde4a9a](fde4a9a)) * remove redundant platform check from musl detection ([#64](#64)) ([0d4829c](0d4829c)) * require writable external buffer storage ([#58](#58)) ([8fd898f](8fd898f)) * restore registerDecls on Zig 0.16 ([#59](#59)) ([7f3af3e](7f3af3e)) ### Code Refactoring * **js:** unify env lifecycle refcounting ([#53](#53)) ([d3d5056](d3d5056)) ### Miscellaneous Chores * define changelog sections for release-please ([#54](#54)) ([1c5e7b4](1c5e7b4)) * update dev deps ([#74](#74)) ([5121590](5121590)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
External ArrayBuffer and Buffer constructors accepted
[]const u8and removed constness before exposing the backing memory to JavaScript. JavaScript can mutate that memory, so immutable storage such as string literals could be written through, causing undefined behavior.Callers with immutable input also need an owning copy API instead of being pushed toward the zero-copy external constructors.
Description
[]u8for external ArrayBuffer and Buffer backing storage and remove the internal@constCastoperations..external_bufferreturn hint.createArrayBufferCopyfor immutable input and document the existing Buffer copy behavior.Validated with
pnpm build,pnpm test:zig, and the hello-world Vitest suite. The full JS suite retains the pre-existing macOS musl-target failure inexamples/targets/mod.test.ts.