Fix Soroban contract initialization, pure reads, and string bounds - #212
Fix Soroban contract initialization, pure reads, and string bounds#212devfoma wants to merge 4 commits into
Conversation
…ve compilation issues
|
Thanks for this PR! It currently has merge conflicts against |
|
@devfoma resolve conflict and pr differently for the different else if will reflect in ur dashboard |
|
This PR currently has merge conflicts with the base branch. Please update the branch from |
|
I rechecked this PR against the current main branch and it still needs author/code-owner conflict resolution before it can be merged safely. The local merge hits broad conflicts including �pp/dashboard/admin/kyc-management/page.tsx, components/dashboard/sidebar.tsx, and add/add Soroban contract conflicts in contracts/chainmove-pool/src/lib.rs and contracts/repayment/src/lib.rs, along with a large stale branch delta. Because this requires deciding the current dashboard/sidebar and contract architecture, I am leaving it unmerged instead of guessing behavior on the author's behalf. Please rebase/merge current main, resolve those conflicts, and request another review. |
This PR resolves three critical issues regarding contract security, Soroban API interactions, and resource costs.
Changes
Closes #163
Closes #179
Closes #169