Add polling configuration options for ChannelFinder updates#145
Merged
jacomago merged 2 commits intoChannelFinder:masterfrom May 4, 2026
Merged
Add polling configuration options for ChannelFinder updates#145jacomago merged 2 commits intoChannelFinder:masterfrom
jacomago merged 2 commits intoChannelFinder:masterfrom
Conversation
jacomago
requested review from
anderslindho,
domonkos-ess,
georgweiss,
imretoth-ess,
shroffk,
simon-ess and
tynanford
Contributor
simon-ess
reviewed
May 4, 2026
- Introduced `pushMaxRetries` and `pushAlwaysRetry` settings in demo and full configuration files. - Updated CFConfig class to handle new push parameters. - Enhanced push logic to respect retry count and infinite retry options. Co-authored-by: Copilot <copilot@github.com>
|
simon-ess
approved these changes
May 4, 2026
| sleep *= 1.5 | ||
| _log.info("Polling %s complete", ioc_info) | ||
| return success | ||
| _log.error("Pushing updates for %s complete, failed after %d attempts", ioc_info, count) |
Contributor
There was a problem hiding this comment.
This message is a bit odd "complete" but "failed after" seem at odds with each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pollingRetryCountandpollingInfiniteRetriessettings in demo and full configuration files.