Mixed bugfixes#146
Merged
anderslindho merged 5 commits intomasterfrom May 4, 2026
Merged
Conversation
`struct.Struct.unpack` returns a tuple, so `record_id = _ping.unpack(...)` was binding the single-element tuple `(value,)` rather than the int. Every del-record handoff to the session was therefore receiving the wrong type, which silently broke deletion in any backend that compared `record_id` by value.
Twisted's DatagramProtocol.datagramReceived expects (datagram, addr), not a single positional argument. The wrong signature would raise a TypeError if a datagram arrived despite the transport being paused.
simon-ess
reviewed
May 4, 2026
CastFactory.buildProtocol computed the active flag correctly but never incremented NActive, so the maxActive limit was permanently bypassed. Every connection was accepted as active regardless of configured limit, causing thundering-herd overload on restart with large IOC counts.
|
jacomago
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for descriptions. In particular the NActive issue seems highly relevant for critical issues we have in production at ESS, for our largest sub-network (~2500 IOCs).