fix(processors): add missing getint to ConfigAdapter (#145 regression)#148
Merged
Conversation
CFConfig.loads() called conf.getint() to parse pushMaxRetries, but ConfigAdapter only implemented get() and getboolean(). This caused an AttributeError on startup in any deployment using the cfstore processor.
The existing suite is entirely Docker integration tests, leaving the configuration parsing path untested. Cover ConfigAdapter.get, getboolean, and getint (including missing-key and invalid-value fallback) and CFConfig.loads defaults and overrides so regressions like the missing getint method are caught without needing Docker.
jacomago
approved these changes
May 5, 2026
Verifies the container reaches the CF connection attempt (CF_START in logs) rather than crashing during config parsing. A missing method on ConfigAdapter would cause an AttributeError in makeService, before the log system is even configured, so CF_START would never appear.
|
jacomago
approved these changes
May 5, 2026
jacomago
reviewed
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 introduced a breaking bug, which was not caught by CI because the entire test suite consists of Docker integration tests - there were no tests exercising the configuration parsing path.
We will need an immediate new patch release (1.9.4) after this MR.