Repository cleanup: dead packaging, uncollected tests, stale docs - #176
Merged
Conversation
DS_Store was missing its leading dot and `.*.swp` did not match a bare `.swp` or `.swo`, so both kept showing up as untracked for anyone without a global ignore file covering them.
The clang-format hook only ever applied to the C sources under `client/`, which have moved to ChannelFinder/reccaster. The remaining comments came from the upstream hook templates, and the file was missing the trailing newline `end-of-file-fixer` expects.
UTF-8 is the default source encoding in Python 3; these are left over from when the tree also supported Python 2.
The entry still read `docker-compose.yml`, so it matched nothing and the compose file was copied into the build context.
It cannot build. `debian/rules` drives an EPICS build under `client/`, which is now a stub, and the packaging targets Python 2.7 throughout. Nothing in the repository or in CI references it, and the sqlite3 initialisation that `debian/README` documented is also in `server/README.md`.
`server.yml` addresses `tests/unit`, `tests/integration` and `tests/container` individually, so the two files at the top of `tests/` ran under a local `pytest tests` but never in CI. `test_recast.py` is renamed on the way because the name is taken below `unit/`.
It documents the same options as `demo.conf` and had drifted: `commitSizeLimit` was missing, and `pushAlwaysRetry` lacked the note that enabling it blocks commits for every IOC until ChannelFinder recovers.
The integration IOC services wait on `recc` being healthy, and what they need is RecCeiver's TCP listener. The check looked for an established connection to ChannelFinder instead, which reflects `requests` connection pooling rather than whether RecCeiver is up. `timeout` was also longer than `interval`, so probes could overlap.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping accumulated since reccaster moved out, one commit per concern.
Two worth a look before the rest. The debian packaging is removed; it cannot
build, but it is the one change with reach outside the repository, so say if any
site still builds from it. The README changes describe current state only and
leave the framing quoted in #174 unchanged, so that question stays open.