Skip to content

Cellml download retry - #40

Merged
mirams merged 3 commits into
mainfrom
cellml_download_retry
Jul 28, 2026
Merged

Cellml download retry#40
mirams merged 3 commits into
mainfrom
cellml_download_retry

Conversation

@kwabenantim

Copy link
Copy Markdown
Member

Fixes #39

@kwabenantim
kwabenantim marked this pull request as draft July 25, 2026 13:06
@kwabenantim
kwabenantim requested a review from Copilot July 25, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses intermittent CI configuration failures (Issue #39) by making the CellML fetch step more robust during CMake configuration, reducing the likelihood of GitHub rate limiting and ensuring configuration fails fast when CellML retrieval cannot succeed.

Changes:

  • Switch CellML retrieval from 14 individual file(DOWNLOAD ...) calls to a single GitHub tarball download at a pinned revision.
  • Add bounded retry logic with backoff for the archive download, and make download/unpack failures fatal to configuration.
  • Update legacy documentation links in CMake and README to the current Chaste documentation site.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
CMakeLists.txt Reworks CellML fetching to download + unpack a single archive with retries and fatal failure on error.
README.md Updates the “Getting Started” documentation link to the new Chaste docs site.
apps/CMakeLists.txt Updates legacy Chaste CMake build guide link.
test/CMakeLists.txt Updates legacy Chaste CMake build guide link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kwabenantim
kwabenantim marked this pull request as ready for review July 25, 2026 13:43
@kwabenantim
kwabenantim requested a review from mirams July 27, 2026 09:31
@mirams

mirams commented Jul 27, 2026

Copy link
Copy Markdown
Member

Is something clever making the tarball and making it available automatically? If not it is probably just a bit of hassle that I won't remember how to do (or that I need to do) when adding a new CellML file. Can we just re-try the individual file downloads?

@kwabenantim

Copy link
Copy Markdown
Member Author

Is something clever making the tarball and making it available automatically? If not it is probably just a bit of hassle that I won't remember how to do (or that I need to do) when adding a new CellML file. Can we just re-try the individual file downloads?

It's GitHub making the tarball using the same url on the repo page (I've updated this now.)

I can make it fetch individual files again if that will be easier to maintain.

@mirams
mirams merged commit b359c7a into main Jul 28, 2026
1 check passed
@mirams
mirams deleted the cellml_download_retry branch July 28, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make cellml download more robust

3 participants