fix(external-webhooks): accept provider from input instead of hardcoding make - #900
Merged
Merged
Conversation
…ing make POST /v1/external-webhooks always stamped provider: "make" server-side, even though the field is just metadata (nothing branches on its value). Accept it from the request body as an enum(["make", "n8n"]) defaulting to "make", so other automation platforms (e.g. n8n) registering a webhook get an accurate provider label instead of being mislabeled as Make. Existing Make callers are unaffected since they never sent this field and the default preserves current behavior exactly.
viethung0o0
pushed a commit
that referenced
this pull request
Sep 7, 2026
…ing make (#900) POST /v1/external-webhooks always stamped provider: "make" server-side, even though the field is just metadata (nothing branches on its value). Accept it from the request body as an enum(["make", "n8n"]) defaulting to "make", so other automation platforms (e.g. n8n) registering a webhook get an accurate provider label instead of being mislabeled as Make. Existing Make callers are unaffected since they never sent this field and the default preserves current behavior exactly. Co-authored-by: Deathgiver <anonymous@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/external-webhooksalways stampedprovider: "make"server-side, even though the field is pure metadata (nothing in the codebase branches on its value).providerfrom the request body asz.enum(["make", "n8n"]).default("make"), so other automation platforms (e.g. n8n) registering a webhook get an accurate label instead of being mislabeled as Make.Changes
apps/builder/src/features/external-webhooks/api/workspace-token.ts—createExternalWebhookWorkspaceTokenAPIinput now includesprovider, handler passesinput.providerthrough instead of the hardcoded string.Test plan
pnpm lint— cleanpnpm --filter builder check-types— cleanprovider, so the.default("make")preserves current behavior exactly; confirmed no code anywhere branches onprovider's value (greppedapps/builder,apps/worker,packages/business).