Skip to content

refactor(worker): delete each workspace as soon as its teardown finishes - #932

Merged
viethung0o0 merged 1 commit into
mainfrom
refactor/workspace-purge-delete
Aug 10, 2026
Merged

refactor(worker): delete each workspace as soon as its teardown finishes#932
viethung0o0 merged 1 commit into
mainfrom
refactor/workspace-purge-delete

Conversation

@viethung0o0

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #931. During the scheduled workspace purge, each workspace row is now removed as soon as its own teardown finishes, instead of waiting to remove them all together at the end of the batch.

Behavior

  • A workspace is deleted immediately after it is torn down cleanly.
  • A workspace whose teardown fails keeps its row and is retried on the next run.
  • Deletions run with bounded concurrency alongside the teardown work.

Test plan

  • business workspace service tests (per-workspace deletion covered)
  • type-check on the changed file
  • lint on the changed files

Note: the repo-wide type-check hook currently fails on unrelated, pre-existing errors in other packages; the file changed here type-checks clean.

@viethung0o0
viethung0o0 force-pushed the refactor/workspace-purge-delete branch from 5e2fb94 to 5b38dd6 Compare August 10, 2026 04:25
@viethung0o0
viethung0o0 merged commit f771183 into main Aug 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Refactor or performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants