Skip to content

Conversation

@SivanShl
Copy link
Contributor

No description provided.

@SivanShl
Copy link
Contributor Author

Adding the option to reuse a group name rather than creating a new one so all the data will be added to the existing name

@chkp-ofirs
Copy link
Contributor

Hi,
Please:

  1. explain what was added? if this is a new switch, explain the default value.
  2. Add an example of a user message in case an object exists
  3. Remove comments , you have a todo in code

@chkp-ofirs
Copy link
Contributor

added command line argument that SmartConnector should use reuse the group by name instead of creating a new group.
--reuse-group-name', default="false"

@chkp-ofirs chkp-ofirs merged commit 036fe37 into CheckPointSW:staging Oct 20, 2022
@SivanShl
Copy link
Contributor Author

Added the option to Reuse the same name group instead of creating a new one. I added a flag '--reuse-group-name' that gets 'true' | 'false', the default is false.
The SmartConnector gets the JSON file and if there are duplicates with the database group names or in the JSON file it creates a new name to the new data by adding '_1' '_2' and so on at the end of the name,
Now, if there are duplicate names and the user uses the 'reuse-group-name' flag, it will add the new data to the existing group name instead of creating a new one.
example of a user message without the flag - 'REPORT: MBC_SCOM is added as MBC_SCOM_1'
example of a user message with the flag - 'REPORT: Using the existing object MBC_SCOM'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants