Skip to content

change from string interpolation to simple string operation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2020
Merged

change from string interpolation to simple string operation #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e99723
change from string interpolation to simple string operation
alex-vertiy Feb 10, 2020
561e4a2
Merge pull request #6 from chkp-yaelg/cisco_fix
chkp-yaelg Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CiscoMigration/CiscoConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,12 +1706,12 @@ private void Add_TimeRanges()
bool isRenamed = false;
foreach (string periodic in caTime.PeriodicsList)
{
string postfixString = $"_{postfixIndex++}";
string postfixString = "_" + postfixIndex++;
string cpTimeRangeName = cpTimeRangeNameSrc + postfixString;

while (cpTimeRangeName.Length > cpTimeRangeNameLength || cpTimeRangesNamesUniq.Contains(cpTimeRangeName))
{
string cpTimeNamePostfixStr = $"_{cpTimeNamePostfixInt}";
string cpTimeNamePostfixStr = "_" + cpTimeNamePostfixInt;
cpTimeRangeName = cpTimeRangeNameSrc.Substring(0, cpTimeRangeNameLength - cpTimeNamePostfixStr.Length - postfixString.Length);
cpTimeRangeName = cpTimeRangeName + cpTimeNamePostfixStr + postfixString;
isRenamed = true;
Expand All @@ -1728,7 +1728,7 @@ private void Add_TimeRanges()
{
while (cpTimeRangeNameSrc.Length > cpTimeRangeNameLength || cpTimeRangesNamesUniq.Contains(cpTimeRangeNameSrc))
{
string cpTimeNamePostfixStr = $"_{cpTimeNamePostfixInt}";
string cpTimeNamePostfixStr = "_" + cpTimeNamePostfixInt;
cpTimeRangeNameSrc = cpTimeRangeNameSrc.Substring(0, cpTimeRangeNameLength - cpTimeNamePostfixStr.Length);
cpTimeRangeNameSrc = cpTimeRangeNameSrc + cpTimeNamePostfixStr;
cpTimeNamePostfixInt += 1;
Expand All @@ -1754,7 +1754,7 @@ private void Add_TimeRange(int caTimeId, string caTimeRangeName, string cpTimeRa
new ConversionIncident(
caTimeId,
"TITLE: object is renamed",
$"DESCRIPTION: object renamed from {caTimeRangeName} to {cpTimeRangeName}",
"DESCRIPTION: object renamed from " + caTimeRangeName + " to " + cpTimeRangeName,
ConversionIncidentType.Informative));
}

Expand Down