Skip to content

PAN-OS: fix the bug with infinite recursion #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chkp-ofirs merged 1 commit into from
Jul 21, 2022
Merged

PAN-OS: fix the bug with infinite recursion #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions PaloAltoMigration/PaloAltoConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4269,6 +4269,19 @@ public void AddCpServiceGroup(CheckPoint_ServiceGroup cpSrvGroup,
}
else if (cpSrvGroupsDict.ContainsKey(member))
{
//if cpSrvGroupsDict contains a member
//whose members have a copy of the original member,
//then we get an infinite recursion
//to fix the bug we are skipping the call of the same member
var infiniteRecursion = false;
foreach (string subMember in cpSrvGroupsDict[member].Members)
{
if (subMember == member)
{
infiniteRecursion = true;
}
}
if (!infiniteRecursion)
AddCpServiceGroup(cpSrvGroupsDict[member], cpServicesDict, cpSrvGroupsDict);
AddCheckPointObject(cpSrvGroupsDict[member]);
}
Expand Down