Skip to content

Conversation

@SivanShl
Copy link
Contributor

No description provided.

@chkp-ofirs
Copy link
Contributor

chkp-ofirs commented Oct 19, 2022

Hi,
Please resolve conflicts and explain what was added to this commit

@SivanShl
Copy link
Contributor Author

Adding the option to optimize by comments in CISCO and FirePower vendors by using a flag or by checking the check box

@chkp-ofirs
Copy link
Contributor

Adding the option to optimize by comments in CISCO and FirePower vendors by using a flag or by checking the check box

Please:

  1. Explain the new logic
  2. which flow calls this logic?
  3. What is the new command line option? what is the default value?

@SivanShl
Copy link
Contributor Author

SivanShl commented Oct 20, 2022

Added an option to optimize by comments, I added a checkbox on the UI on CISCO and FirePower vendors, in addition, I added a flag on the command line - '-obc | --optimize-by-comments' that get 'true' | 'false', the default is false.
The SmartMove has rulebase to merge several rules from the same sub-policy into a single rule.
In the optimize by comments option the App passes all the rules and checks if there is a match between their comments and if the 'optimize by comments' flag is true or the checkbox is checked, if there is a match and in addition the rulebase is applied the rules are merged into one rule.

@chkp-ofirs chkp-ofirs merged commit 2e4d172 into CheckPointSW:staging Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants