Update README #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the examples in the README to use "api_*" instead of "consumer_*". Using consumer_ returns an error from Checkfront about a malformed auth header.
Contributor
|
Hi @christohill, can you give us more information about the error you're seeing? Your proposed change might also require the addition of an Specifically, I'm referring to the code following line 105 of the constructor in https://github.com/Checkfront/PHP-SDK/blob/master/lib/CheckfrontAPI.php |
Contributor
Author
|
@k-jackson That's fair, I didn't try the oauth2 authentication and when I read through the constructor I stopped at the token auth type. Maybe just adding a second example for the token auth method and labeling each? |
Added a second example for users using the token auth type to distinguish the difference between api_* and consumer_* config values
gegere
added a commit
to htmlgraphic/Checkfront-PHP-SDK
that referenced
this pull request
Nov 27, 2017
gegere
added a commit
to htmlgraphic/Checkfront-PHP-SDK
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the examples in the README to use "api_" instead of "consumer_". Using consumer_ returns an error from Checkfront about a malformed auth header.