Add guideline on closing a PR#148
Conversation
Updating my fork
Added the guideline on closing a PR when it has been inactive for at least 14 days
| 4. **Push** your work back up to your forked repository | ||
| 5. Submit a **Pull request** (PR) so that we can review your changes | ||
|
|
||
| ⚠ Pull requests without any activity for at least 14 days will be closed. To avoid this, please reply when asked for more information or update your PR in case in didn't meet the requirements (e.g. failed checks). |
There was a problem hiding this comment.
Please be consistent in the line length with the rest of the file. I think the maximum length is ~100 characters. A possible exception are URLs or other language constructs which have to be in a single line.
|
Request for clarification: Is this for PR's that have failed testing, or all PR's? |
I think we should clarify that this statement is about missing activity on the contributor's side after being asked to change something. It just wouldn't make any sense to auto-close PRs if the we (= the project's team) are too slow responding to it or we haven't decided how/when to merge the PR or parts of it. So #28 or #116 are definitely not in danger of being autoclosed... 😉 |
-Formatted the guidelines to be <100 characters per line. -Clarified that it concerns cases where the author didn't respond.
|
Merged, thanks! |
Change-Id: I46562a167b38b37217780ac56225390fa47ef11e
4 participants
Added the guideline that PRs with no activity for at least 14 days will be closed.