Skip to content

Add guideline on closing a PR #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fayepal wants to merge 4 commits into from
Closed

Add guideline on closing a PR #148

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e1a1f4
Update this fork
fayepal Mar 9, 2020
b9be274
Merge pull request #2 from tribe29/master
fayepal Mar 26, 2020
eae4ddb
Add the guideline on closing a PR
fayepal Mar 26, 2020
14c7c29
Edit the PR guideline based on comments
fayepal Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ this:
3. **Commit** changes to your own feature branch
4. **Push** your work back up to your forked repository
5. Submit a **Pull request** (PR) so that we can review your changes

⚠ Please reply when asked for more information or to update your PR
in case in didn't meet the requirements (e.g. failed checks).
If there's no response from the author for at least 14 days, the PR will be closed.

If it’s your first time to contribute to an open source project, we recommend reading [this guide](https://opensource.guide/how-to-contribute/). You may also want to try the [GitHub Hello World tutorial](https://guides.github.com/activities/hello-world/).

Expand Down Expand Up @@ -212,7 +216,9 @@ The public repository of [Checkmk](https://github.com/tribe29/checkmk) is
integrated with Travis CI. Each time a Pull request is submitted, Travis will
have a look at the changes.

**Important:** We only review PRs that are confirmed to be OK by Travis.
**⚠ Important:** We only review PRs that are confirmed to be OK by Travis.
If a check failed, please fix it and update the PR.
PRs will be closed if the author didn't respond for at least 14 days.

It is recommended to run all tests locally before submitting a PR. If you want
to execute the full test suite, you can do this by executing these commands in
Expand Down