Skip to content

Linux agent: standardise function declarations, add/implement inpath function - #18

Closed
rawiriblundell wants to merge 1 commit into
Checkmk:masterfrom
rawiriblundell:master
Closed

Linux agent: standardise function declarations, add/implement inpath function#18
rawiriblundell wants to merge 1 commit into
Checkmk:masterfrom
rawiriblundell:master

Conversation

@rawiriblundell

Copy link
Copy Markdown
Contributor

Hi,
This change removes all instances of the 'function' keyword, which is considered to be deprecated, obsolete and non-POSIX.

Function declarations have been done using three different approaches, I have standardised to this style:

functionname() {

I have added a function, inpath(), which abstracts all instances of if type [some command] >/dev/null. This removes several instances of > /dev/null and > /dev/null 2>&1

The approved changes in my previous PR appear to have disappeared, so they are in here as well.

@LarsMichelsen

Copy link
Copy Markdown
Member

Please rebase to current upstream. Your changes are there

LarsMichelsen pushed a commit that referenced this pull request Jun 6, 2019
fixes #18

Change-Id: I652332ca14c4d0d53a462067410a06e9fee0d47e
LarsMichelsen pushed a commit that referenced this pull request Oct 25, 2019
fixes #18

Change-Id: I652332ca14c4d0d53a462067410a06e9fee0d47e
LarsMichelsen pushed a commit that referenced this pull request May 2, 2022
cmk.gui.watolib.changes

CMK-10313

Change-Id: Ib6573b180fddd6db84e5f6ef3f29fa7d7c16ff04
CheckmkCI pushed a commit that referenced this pull request Jul 8, 2024
Change-Id: I214729a9f7266626c12af2b44149f5c992bdd4f7
CheckmkCI pushed a commit that referenced this pull request Jul 8, 2024
Change-Id: I339849720d0c26fc4ea28f59ce1f6630c7f5ec6c
CheckmkCI pushed a commit that referenced this pull request Jul 8, 2024
Change-Id: I8a9f460e3b7ec7c87cbd03b00ccf3933eb056b15
CheckmkCI pushed a commit that referenced this pull request Jul 10, 2024
Change-Id: Ibc485208716d3bba507d9c8874e3644133d27f21
CheckmkCI pushed a commit that referenced this pull request Jun 30, 2025
Change-Id: I30f59d751ecac9d87603b2c6a6f1ba64e1772306
CheckmkCI pushed a commit that referenced this pull request Jul 28, 2025
Change-Id: I92babe6ecd06467777fcbce88739c0a712335673
CheckmkCI pushed a commit that referenced this pull request Jul 29, 2025
Change-Id: I73aae15c2cedb9f51ba7f39419fc42df3e464d45
CheckmkCI pushed a commit that referenced this pull request Jul 30, 2025
Change-Id: I9173841ba1b03f308571ae9d474c02f6dc877512
CheckmkCI pushed a commit that referenced this pull request Feb 12, 2026
Change-Id: Ief393579f7aec661080077b5176356154c57fdc5
CheckmkCI pushed a commit that referenced this pull request Mar 25, 2026


These tests can later be executed separately by the individual edition
test targets without conditional.

CMK-32598

Change-Id: I07c048f32d0a34678d49bf20f7583e5565a6dccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants