Skip to content

Use registry-backed server image in production packages#90

Merged
den-sq merged 1 commit into
staging/release-packaging-smokefrom
codex/issue-88-registry-server-package
Jul 1, 2026
Merged

Use registry-backed server image in production packages#90
den-sq merged 1 commit into
staging/release-packaging-smokefrom
codex/issue-88-registry-server-package

Conversation

@den-sq

@den-sq den-sq commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a production server resource generator that writes extra-resources/server/compose.yml with a GHCR image reference
  • include server-image.json metadata for the exact repository/tag/digest used by a package
  • update the app release workflow to prepare registry-backed server resources instead of bundling Python wheel/Dockerfile build inputs
  • document tag and digest usage for release packaging

Verification

  • node --check scripts/prepare-production-server.mjs
  • OUROBOROS_SERVER_IMAGE_TAG=v9.9.9 npm run prepare:production-server
  • inspected generated extra-resources/server/compose.yml
  • inspected generated extra-resources/server/server-image.json

Closes #88.

@tavateva

tavateva commented Jul 1, 2026

Copy link
Copy Markdown

Draft Promotion Review ✅ READY

Reviewed against Draft Promotion Criteria.

Context: This PR addresses issue #88 (Use registry-backed server image in production packages).

Criterion Assessment

  1. CI and mergeability: ✅ PASScoverage and docs checks green, mergeable
  2. Issue Acceptance Criteria: ✅ PASS — All 4 criteria met:
    • ✅ Production package includes compose with GHCR image reference
    • ✅ First launch pulls image (no build: in generated compose)
    • ✅ Development compose unchanged (still builds from source)
    • ✅ Documentation updated (registry-server-images.md)
  3. PR body Test Plan checkboxes: ✅ PASS — All verification items executed:
    • node --check scripts/prepare-production-server.mjs
    • npm run prepare:production-server with test tag
    • ✅ Generated extra-resources/server/compose.yml inspected
    • ✅ Generated extra-resources/server/server-image.json inspected
  4. Tests run: ✅ PASS — Script validation and output inspection reported
  5. Scope: ✅ PASS — Focused on registry image integration; removed wheel/Dockerfile bundling from release workflow
  6. Regressions: ✅ PASS — CI green; generated compose preserves ports/volumes/environment
  7. Judgement calls: ✅ PASS — Image tag/digest defaulting logic documented inline in script

VERDICT: ✅ READY TO MERGE

Key Changes

  • scripts/prepare-production-server.mjs: Generates registry-backed compose.yml from env vars
  • Release workflow: Replaced Python/Poetry steps with npm run prepare:production-server
  • Compose output: Uses image: ghcr.io/chenglabresearch/ouroboros-server:<tag> instead of build:
  • Metadata: server-image.json tracks exact image/tag/digest/commit for package

All 7 criteria satisfied. This PR closes issue #88 and is ready to merge.

@den-sq den-sq self-assigned this Jul 1, 2026
@den-sq den-sq changed the base branch from main to staging/release-packaging-smoke July 1, 2026 19:56
@den-sq den-sq merged commit 47d5a87 into staging/release-packaging-smoke Jul 1, 2026
2 checks passed
@den-sq den-sq deleted the codex/issue-88-registry-server-package branch July 1, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use registry-backed server image in production packages

2 participants