Fix lost-wakeup race in WorkScheduler serial task wait#10071
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential lost-wakeup race in the execution WorkScheduler when it waits for completion of a serial task (e.g., a mutation root field), and adds a regression test that stresses the specific concurrency window that previously could hang requests indefinitely.
Changes:
- Make the “completed check” and
_signal.Reset()occur within the same_synclock region while waiting for a serial task, preventing a lost wakeup. - Refactor dispatch/completion logic into a locked
TryDispatchOrCompleteUnsafe(...)helper to safely reuse logic from the wait path. - Add an integration stress test that runs many concurrent mutation executions with an async child resolver that yields to exercise the race window.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Core/test/Execution.Tests/Integration/Spec/MutationTests.cs | Adds a high-concurrency regression test to detect hangs/timeouts caused by lost-wakeup behavior while awaiting serial mutation tasks. |
| src/HotChocolate/Core/src/Types/Execution/Processing/WorkScheduler.Execute.cs | Fixes the lost-wakeup window by performing completion visibility check + signal reset under the same lock; refactors dispatch/completion logic for safe reuse. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10051