[Fusion] Perfomance Optimizations#10073
Merged
Merged
Conversation
…segment allocation
…dd path pool striping
michaelstaib
force-pushed
the
mst/perf-080726
branch
from
0b5b310 to
cb9a542
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on performance optimizations in the Fusion execution layer, primarily around reducing overhead when reading metadb rows and building paths during result traversal.
Changes:
- Replaced several
MemoryMarshal.Read/span-slice reads inCompositeResultDocument.MetaDbwithUnsafe.ReadUnaligned+ direct row-byref access. - Added
[SkipLocalsInit]toCreateCompactPathto reduce stack zeroing overhead withstackallocbuffers. - Enabled unsafe blocks for the Fusion.Execution project and adjusted
ExecutionState.Reset()to clear aConcurrentQueueby draining it.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.MetaDb.cs | Introduces RowRef and switches multiple row-field reads to Unsafe.ReadUnaligned for faster access. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.cs | Applies [SkipLocalsInit] to CreateCompactPath to reduce stack initialization costs. |
| src/HotChocolate/Fusion/src/Fusion.Execution/HotChocolate.Fusion.Execution.csproj | Enables <AllowUnsafeBlocks>true</AllowUnsafeBlocks> for the project. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/ExecutionState.cs | Replaces queue clearing with a dequeue loop to reset completed results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+593
to
+599
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private readonly ref byte RowRef(Cursor cursor) | ||
| { | ||
| var chunk = _chunks[cursor.Chunk]; | ||
| ref var data = ref MemoryMarshal.GetArrayDataReference(chunk.Buffer); | ||
| return ref Unsafe.Add(ref data, chunk.Offset + cursor.ByteOffset); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.