Skip to content

Fix Public API Github Action#4366

Merged
michaelstaib merged 9 commits intomainfrom
tte/fix-public-api
Nov 8, 2021
Merged

Fix Public API Github Action#4366
michaelstaib merged 9 commits intomainfrom
tte/fix-public-api

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

@tobias-tengler tobias-tengler commented Nov 1, 2021

Changes

  • The GitHub action was missing .NET 6, so I added it
  • dotnet format is now part of .NET 6 and the syntax has changed slightly
  • Changed severity of RS0016 or else the analyzer fix is not triggered

@tobias-tengler tobias-tengler marked this pull request as ready for review November 8, 2021 17:07
@tobias-tengler tobias-tengler changed the title WIP: Fix Public API Github Action Fix Public API Github Action Nov 8, 2021
Comment thread .editorconfig
dotnet_style_require_accessibility_modifiers = always

# Public API
dotnet_diagnostic.RS0016.severity = warning
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I read that these now have to be warnings in the .editorconfig to be considered. Just could not connect the dots :)

@michaelstaib michaelstaib merged commit e202ffc into main Nov 8, 2021
@michaelstaib michaelstaib deleted the tte/fix-public-api branch November 8, 2021 18:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants