Skip to content

Added PL Language Pack#56

Merged
ChocoMeow merged 2 commits into
ChocoMeow:betafrom
VeeoN2:main
Apr 13, 2025
Merged

Added PL Language Pack#56
ChocoMeow merged 2 commits into
ChocoMeow:betafrom
VeeoN2:main

Conversation

@VeeoN2
Copy link
Copy Markdown
Contributor

@VeeoN2 VeeoN2 commented Apr 11, 2025

Added Polish Language Pack

Copy link
Copy Markdown
Owner

@ChocoMeow ChocoMeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request adding Polish language support to our project! However, I noticed some issues in your language pack:

Key playlistNotInvalidUrl is not found in PL.json.
Key setStageAnnounceTemplate is not found in PL.json.
Key setPrefix is missing parameter 0.
Key pingfield1 is missing parameter 2.
Key pingfield2 is missing parameter 1.
Key playlistNotInvalidUrl cannot exist in PL.json.
Key trackLoad_pos is missing parameter 2.
Key SetStageAnnounceTemplate cannot exist in PL.json.

Please take a look at these issues so we can improve the language support. Thank you!

@ChocoMeow ChocoMeow changed the base branch from main to beta April 12, 2025 02:43
@VeeoN2
Copy link
Copy Markdown
Contributor Author

VeeoN2 commented Apr 12, 2025

I've fixed issues in PL.json file, however keys: pingfield1 and pingfield2 seem to be correct (identical to those in other language files) so i left them as they were.

Copy link
Copy Markdown
Owner

@ChocoMeow ChocoMeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great. thank you so much <3

@ChocoMeow ChocoMeow merged commit 43bf237 into ChocoMeow:beta Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants