Docs: 2026-07-17 overnight delivery sweep (11 PRs) - #1389
Conversation
Self-review (adversarial accuracy pass) — docs-onlyScope: 4 files, +32/-7. No source changes. Reviewed for the one failure mode that matters on a delivery-sweep: overclaiming or misattributing merged work. Verification performed
Findings by severity
Residual risk / NOT verified
|
There was a problem hiding this comment.
Code Review
This pull request updates several documentation files, including the implementation masterplan, status reports, and agentic failure ledgers, to reflect the delivery of eight merged pull requests from the July 17, 2026 substrate and correctness wave. The review feedback is highly constructive, pointing out minor copy inconsistencies regarding the REVIVAL-02 ship gate description in both docs/IMPLEMENTATION_MASTERPLAN.md and docs/STATUS.md, as well as correcting a broken markdown bold syntax rendering error in docs/STATUS.md.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Update: three late-landing PRs folded in (commit 7bfff9d)Three more PRs merged to
Also updated: the entry's "Still open — NOT shipped" line now reads #1386 (final review round in flight) plus the human-gated holds #1295 / #1337 / #1359, since #1381 and #1385 have shipped. Mirrored identically in Re-verified after the fold-in:
|
…nfidence label (Gemini M1/M2)
Fix evidence — Gemini review (3 MEDIUM findings)
Gates re-run after 36fb655: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36fb655fa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Docs-only post-merge sweep for the 2026-07-17 overnight run (11 PRs merged to
main; three — #1385, #1381, #1390 — landed after the initial sweep and were folded in at 7bfff9d). No source changes; the underlying issues are already closed by their own merged PRs, so this PR intentionally uses no closing keywords.What changed
docs/STATUS.md— one consolidated dated entry, "Overnight substrate + correctness wave (2026-07-17, 11 PRs merged)", inserted after the existing 2026-07-17 REVIVAL-02 note. It does not restate the in-PR REVIVAL-02: Remove the fake undo timeline and correct reversibility copy (no revert endpoint exists) #1298 / ARCHIVE-06: Re-point automated coverage at the Paper UI - core-loop E2E defaults + Paper axe suite #1274 paragraphs already present; it references them.docs/IMPLEMENTATION_MASTERPLAN.md— matching "Delivery update (2026-07-17)" section in the established format;Last Updatedbumped to 2026-07-17.docs/agentic/failure_ledger.jsonl+ rendereddocs/agentic/FAILURE_LEDGER.md— three ledger rows flipped toresolvedin place (the file's established convention), with the resolving PR recorded infuture_fix. Re-rendered viascripts/agent_hooks/render_failure_ledger.py.Merge set documented (Refs)
Refs #1373 (#1282, shared
UseTaskdeckSqlitetest/prod parity), #1375 (#1298, REVIVAL-02 fake-undo removal), #1374 (#1370, proposal preview==apply), #1372 (#1367, MCP host-security fail-closed), #1377 (#1357, concurrent-migrator final-state assertion), #1378 (#1369, artefact extraction wall-clock budget), #1362 (#1274, Paper P-I E2E ship gate), #1366 (#1365/#1371, presence broadcast delivery proof), #1385 (#1355, batched export blob loads), #1381 (#1368, MCP pre-auth failure budget + per-IP concurrency admission gate + abort-proof consumption), #1390 (same-night hotfix of the #1377 fail-open collision test; flake-run evidence 29552875836).Ledger rows marked resolved (Refs)
test/sqlite-concurrency— Refs Flaky: ConcurrencyRaceConditionStressTests.BoardCreation_ConcurrentMultiUser_NoCrossContamination — transient 500 during concurrent auth setup #1282, resolved via Mirror production SQLite settings in the API test factory #1373frontend/paper-review-contract— Refs Paper Review crashes on numeric deep-review enum payloads #1347, resolved via Fix Paper deep-review enum wire contract #1360 (2026-07-14)backend/similar-past— Refs Similar-past endpoint returns 500 for real SQLite proposals #1348, resolved via Fix SQLite similar-past history query #1361 (2026-07-14)Gates run (all green, re-run after the #1385/#1381/#1390 fold-in)
node scripts/check-docs-governance.mjs— passednode scripts/check-golden-principles.mjs— passedpython scripts/agent_hooks/render_failure_ledger.py— clean idempotent re-render; JSONL parses (14 rows)Accuracy notes
origin/main(20d7f0c, e1ecd28, 493d450), including the Spend MCP pre-auth IP budget only on authentication failures #1381 abort-prooffinallyconsumption and the Make the fail-open collision test deterministically intercept mid-chain #1390 run-29552875836 flake evidence.