Fail closed on skipped container integration - #1559
Conversation
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04438ade4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Chris0Jeky
left a comment
There was a problem hiding this comment.
Fresh-context adversarial review of exact head 5f721ca: no remaining CRITICAL/HIGH findings. The forced-unavailable path is process-scoped and verifies the intended failure in TRX; the positive parser requires zero skips and at least 28 PostgreSQL-backed results while excluding fixture infrastructure and SQLiteNativeVersionTests; the new 27-PostgreSQL-plus-SQLite canary closes the earlier false-green. The hosted positive container job remains the required runtime evidence before owner merge.
Summary
Implementation notes
Ordinary Dockerless runs keep the existing graceful-skip path. The reusable Ubuntu workflow sets
TASKDECK_REQUIRE_DOCKER=true; a forced-unavailable process is expected to fail before the real Docker-backed run.Tests
py -3 -B -m unittest scripts/ci/test_assert_container_integration_results.py— 5 passednode scripts/check-github-ops-governance.mjs— passedDocs
docs/TESTING_GUIDE.mdnow records the hosted required-mode flag, forced-unavailable negative control, and positive TRX zero-skip/minimum-PostgreSQL contract.docs/STATUS.mdanddocs/IMPLEMENTATION_MASTERPLAN.mdremain unchanged because this PR is not yet shipped.Verification boundary
Local Docker Desktop's Linux engine was unavailable, so local positive container startup was not verified. The equivalent exact-head hosted Container Integration job passed and is the authoritative positive PostgreSQL proof. The local full backend run had one unrelated nondeterministic SignalR stress-test failure; its focused rerun passed, and the exact recurrence was recorded on existing owner #1521.
Closes #1520