Skip to content

Honor configured API paths in board recovery test - #2437

Merged
Chris0Jeky merged 3 commits into
mainfrom
issue-2431/api-base-path-recovery
Sep 3, 2026
Merged

Honor configured API paths in board recovery test#2437
Chris0Jeky merged 3 commits into
mainfrom
issue-2431/api-base-path-recovery

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Derive the Paper board-recovery intercept pathname from the configured E2E API base URL.
  • Preserve exact configured prefixes such as /taskdeck/api and normalize a trailing slash.
  • Keep the configured origin and target-board guards unchanged.

Closes #2431

Evidence

Red first on base d3a3f7a:

  • focused Vitest failed on the missing API route-path helper

Green at dc7c549 on current base f59b854:

  • API route-path configuration regression: 3/3 passed for /api, /taskdeck/api, and a trailing slash
  • scoped ESLint: passed with zero warnings
  • npm run typecheck: passed
  • npm run build: passed, 812 modules transformed; existing toast-store dynamic-import warning only
  • default-path Paper recovery Playwright journey: 1/1 passed in 27.7 seconds on isolated ports and data
  • git diff --check origin/main...HEAD: passed
  • fresh current-base review: no CRITICAL/HIGH finding

Review disposition

  • Non-blocking and declined for this PR: older recovery scenarios retain /api suffix predicates. They support the documented /taskdeck/api shape and do not affect this issue's Paper board-recovery seam.

Hosted CI

  • Exact-head Required CI: run 33776691378.
  • Exact-head Smart CI: run 33776688690.
  • Exact-head Smart CI Self-Test: run 33776691046.
  • Exact-head CI Extended: run 33776691637.
  • Check conclusions on this PR are authoritative. The earlier full green run 33765934008 was superseded when PR Protect proposal resource failure details #2436 moved main.

Boundaries

  • Production API routing and Playwright server configuration are unchanged.
  • No live prefixed-path deployment was started; the deterministic configuration regression proves its exact pathname.
  • Canonical docs are unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T16:09:11.236003Z dc7c549 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

[Codex independent review disposition]
base: ebf68e0
head: f3945be

Fresh-context review found no CRITICAL/HIGH direct blocker. The configured origin guard remains, the exact target-board predicate now preserves the configured API pathname, and focused coverage pins /api, /taskdeck/api, and trailing-slash normalization. Focused Vitest 3/3, scoped ESLint, typecheck, production build, default-path Paper recovery Playwright 1/1, and diff check passed. Hosted exact-head CI and automatic review are pending.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 3, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Current-base independent review at dc7c549 against f59b854 found no CRITICAL/HIGH defect.

Verified: the net diff remains the three E2E/helper files, current main has no overlapping frontend change, the route-path regression passed 3/3, and diff hygiene passed.

Non-blocking and declined for this PR: older recovery scenarios retain /api suffix predicates. They support the documented /taskdeck/api shape and are outside #2431's Paper board-recovery acceptance.

@Chris0Jeky
Chris0Jeky merged commit 98f3fbd into main Sep 3, 2026
37 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 3, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-2431/api-base-path-recovery branch September 3, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Testing] Honor configured API base paths in board recovery E2E

1 participant